Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timestamping feature #1758

Merged
merged 2 commits into from
Sep 3, 2024
Merged

feat: timestamping feature #1758

merged 2 commits into from
Sep 3, 2024

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Aug 29, 2024

Description

What this PR does / why we need it:

Added Timestamping feature.
Bump up notation-plugin-framework-go

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1222
Fixes #1756

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/verifier/notation/notation.go 84.61% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/verifier/notation/certstoresbytype.go 92.59% <100.00%> (ø)
pkg/verifier/notation/pluginmanager.go 71.42% <100.00%> (ø)
pkg/verifier/notation/notation.go 98.07% <84.61%> (+6.67%) ⬆️

... and 1 file with indirect coverage changes

Makefile Outdated Show resolved Hide resolved
@junczhu
Copy link
Collaborator Author

junczhu commented Sep 2, 2024

image

@binbin-li binbin-li disabled auto-merge September 3, 2024 04:34
@binbin-li binbin-li merged commit 0cae6c7 into dev Sep 3, 2024
31 checks passed
akashsinghal pushed a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
@junczhu junczhu deleted the notation-go_1.2.0 branch October 23, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump-up notation v1.2.0 Add support for Notary Project timestamped signature
2 participants